Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system test] Run DOCs STs generator only in install goal not verify (during tests) #10558

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[system test] Run DOCs STs generator only in install goal not verify (during tests) #10558

merged 1 commit into from
Sep 9, 2024

Conversation

see-quick
Copy link
Member

@see-quick see-quick commented Sep 9, 2024 •
edited
Loading

Type of change

  • Enhancement / new feature
  • Refactoring

Description

This PR changes the way how we run DOCs STs generator. Currently we run it also when one runs

mvn verify...  (i.e, during tests)

and we do not want it. Instead of this we want to run it during build process

mvn clean install

Checklist

  • Make sure all tests pass

@see-quick see-quick requested review from im-konge and a team September 9, 2024 09:05
@see-quick see-quick self-assigned this Sep 9, 2024
@see-quick see-quick added this to the 0.44.0 milestone Sep 9, 2024
scholzj
scholzj reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And do we ever do mvn install in the Build pipeline for system testsM

@see-quick
Copy link
Member Author

And do we ever do mvn install in the Build pipeline for system testsM

Yes we do

make -C systemtest java_install
make[1]: Entering directory '/home/vsts/work/1/s/systemtest'
echo "Installing root pom ..."
Installing root pom ...
mvn -B -DskipTests -Dmaven.javadoc.skip=true install -f ../pom.xml -N

@see-quick see-quick added ready for merge Label for PRs which are ready for merge and removed needs review labels Sep 9, 2024
@see-quick see-quick merged commit 9d1ddf2 into strimzi:main Sep 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@Frawless Frawless Frawless approved these changes

@kornys kornys kornys approved these changes

@im-konge im-konge im-konge approved these changes

Assignees

@see-quick see-quick

Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Milestone
0.44.0
Development

Successfully merging this pull request may close these issues.
5 participants
@see-quick @scholzj @Frawless @kornys @im-konge